mcp: inject new-protocol metadata in default send path - #1167
Open
jstar0 wants to merge 2 commits into
Open
Conversation
Comment on lines
-1677
to
-1679
| if cs.usesNewProtocol() { | ||
| params = injectRequestMeta(cs, params) | ||
| } |
Contributor
There was a problem hiding this comment.
why not removing this call from all the other client send methods
Contributor
Author
|
Addressed the question on current head
Verification:
Please review the current head when convenient. |
jstar0
force-pushed
the
fix/client-request-meta-fallback
branch
from
August 20, 2026 11:34
d5d0a9e to
6df1f56
Compare
Contributor
Author
|
Rebased and pushed the centralized client request metadata injection fix at head The current head is based on upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several client-originated requests in the >= 2026-07-28 protocol still relied on individual API methods to attach the per-request
_metafields. That left send paths such as notifications and registered custom methods withoutprotocolVersion,clientInfo, andclientCapabilities, so modern servers treated them as legacy or uninitialized requests.This changes the default client send handler to clone outgoing params and inject missing request metadata for modern sessions, while keeping the legacy initialize, ping, logging, root-subscription, and resource subscribe compatibility methods on their existing path.
CallCustomMethodnow relies on the shared send path, so caller params are not mutated just to add metadata before serialization.Tests:
Full
go test ./...currently fails only the existing localhost-protection casesTestSSELocalhostProtection/0.0.0.0_via_localhost_rejects_evil.comandTestStreamableLocalhostProtection/0.0.0.0_via_localhost_rejects_evil.comin this environment; all other packages pass.